Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound: pcm512x-codec: Adding 352.8kHz samplerate support #2975

Merged
merged 1 commit into from
May 17, 2019
Merged

sound: pcm512x-codec: Adding 352.8kHz samplerate support #2975

merged 1 commit into from
May 17, 2019

Conversation

klslz
Copy link

@klslz klslz commented May 16, 2019

352.8kHz support can be added to the pcm512c-codec.

This patch is around for years and usually gets applied in custom kernels (e.g. piCoreplayer).
It allows to convert DoP-128 straight to 352.8kHz PCM.
And it also allows synchronous upsampling from x*44.1, mainly to bypass the internal DSP.

The datasheet doesn't show that 352.8kHz is supported. That's why it is probably missing in the codec.

@pelwell
Copy link
Contributor

pelwell commented May 16, 2019

@clivem You tried to upstream this patch years ago. What happened to it?

@clivem
Copy link

clivem commented May 16, 2019

@pelwell Not sure about that specific patch. I gave up submitting any audio patches to upstream. That codec one might not have even been submitted. I have a vague recollection of trying to get the sample rate increased on the Pi I2S driver first..... IIRC, submitted that in '16. It was ignored at the time, even though Eric Anholt added a Reviewed-by, and it wasn't until over a year later that Matthias Reichl re-submitted it with his name on it and Mark King accepted it. In the meantime, for other reasons I lost all interest in audio on Pi.

@pelwell
Copy link
Contributor

pelwell commented May 17, 2019

Thanks, Clive. I'll have another go at pushing it, but until then we can accept it here.

@pelwell pelwell merged commit 4ed0f31 into raspberrypi:rpi-4.19.y May 17, 2019
@klslz
Copy link
Author

klslz commented May 17, 2019

Great. Thx.

popcornmix added a commit to raspberrypi/firmware that referenced this pull request May 28, 2019
kernel rpi-4.19.y changes for common DTS+overlays

kernel: Cherrypick important w1 fixes
See: raspberrypi/linux#2958

kernel: usb: dwc_otg: Clean up interrupt claiming code
See: raspberrypi/linux#2612

kernel: ASoC: decommissioning driver for 3Dlab Nano soundcard
See: raspberrypi/linux#2923

kernel: sound: pcm512x-codec: Adding 352.8kHz samplerate support
See: raspberrypi/linux#2975

kernel: configs: Enable PIDs cgroup
See: raspberrypi/linux#2968
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request May 28, 2019
kernel rpi-4.19.y changes for common DTS+overlays

kernel: Cherrypick important w1 fixes
See: raspberrypi/linux#2958

kernel: usb: dwc_otg: Clean up interrupt claiming code
See: raspberrypi/linux#2612

kernel: ASoC: decommissioning driver for 3Dlab Nano soundcard
See: raspberrypi/linux#2923

kernel: sound: pcm512x-codec: Adding 352.8kHz samplerate support
See: raspberrypi/linux#2975

kernel: configs: Enable PIDs cgroup
See: raspberrypi/linux#2968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants